db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-4052) SQLChar.copyState() doesn't copy localeFinder
Date Mon, 09 Feb 2009 14:14:59 GMT

    [ https://issues.apache.org/jira/browse/DERBY-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671862#action_12671862
] 

Kristian Waagan commented on DERBY-4052:
----------------------------------------

FWIW, we commented on this already, quite a while ago:
http://www.nabble.com/Bug%2C-or-can-the-code-be-deleted-commented--%28SQLChar%29-td14686112.html#a14686112

> SQLChar.copyState() doesn't copy localeFinder
> ---------------------------------------------
>
>                 Key: DERBY-4052
>                 URL: https://issues.apache.org/jira/browse/DERBY-4052
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.5.0.0
>            Reporter: Knut Anders Hatlen
>            Priority: Minor
>
> The last line of SQLChar.copyState() looks incorrect.
>         this.localeFinder = localeFinder;
> This line doesn't do anything, since the left side and the right side of the assignment
are identical.
> It might be intentional, but in that case there should be a comment explaining why. Looking
at the rest of the method, it looks like the intention is that the right side of the assignment
should be other.localeFinder.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message