db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-4042) org.apache.derby.impl.load.Import needs to escape single quotes
Date Sun, 01 Feb 2009 11:01:59 GMT

     [ https://issues.apache.org/jira/browse/DERBY-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-4042:
--------------------------------------

    Attachment: d4042-1.diff

Attached is a patch (d4042-1.diff) that makes the export and import procedures quote arguments
correctly by using helper methods in IdUtil and StringUtil instead of just putting quotes
around them. The patch also adds a test case to ImportExportTest (the test case is small,
but the test diff is somewhat big because many helper methods had to be changed to allow another
schema than APP to be used).

I have only run the tools test so far, but I will start the full regression suite soon.

I also believe there are some problems in ColumnInfo if the column names in the table to export/import
contain double quotes, but I'll defer that to a followup patch.

> org.apache.derby.impl.load.Import needs to escape single quotes
> ---------------------------------------------------------------
>
>                 Key: DERBY-4042
>                 URL: https://issues.apache.org/jira/browse/DERBY-4042
>             Project: Derby
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 10.4.2.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>         Attachments: d4042-1.diff
>
>
> The code that builds the SQL statement that invokes the Import VTI doesn't properly escape
single quotes. This causes problems for users, see: http://mail-archives.apache.org/mod_mbox/db-derby-user/200901.mbox/%3c21754463.post@talk.nabble.com%3e
> Import.performImport() is the method that needs to be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message