db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Knut Anders Hatlen <Knut.Hat...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-3966) Do not require JRE 1.4 libraries at compile time since SUN's JDK 1.4 went out of support and can be used on JRE 1.4 without any problem
Date Wed, 10 Dec 2008 09:31:54 GMT
Myrna van Lunteren <m.v.lunteren@gmail.com> writes:

> On Tue, Dec 9, 2008 at 1:42 PM, Rick Hillegas (JIRA) <jira@apache.org> wrote:
>>
>>    [ https://issues.apache.org/jira/browse/DERBY-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654973#action_12654973
]
>>
>> Rick Hillegas commented on DERBY-3966:
>> --------------------------------------
>>
>> Hi Bryan,
>>
>> I can (and will) run the regression tests. Other than that, I am relying on the following
assumption:
>>
>> 1) The build target in question behaves as advertised and drops its output into
>>
>>    classes/org/apache/derbyBuild
>>
>> plus the following observation:
>>
>> 2) Nothing in the derbyBuild tree appears in any of our built jar files
>>
>>
>>> Do not require JRE 1.4 libraries at compile time since SUN's JDK 1.4 went out
of support and can be used on JRE 1.4 without any problem
>>> ---------------------------------------------------------------------------------------------------------------------------------------
>>>
>>>                 Key: DERBY-3966
>>>                 URL: https://issues.apache.org/jira/browse/DERBY-3966
>>>             Project: Derby
>>>          Issue Type: Task
>>>          Components: Build tools
>>>            Reporter: Pedro Faundez Gonzalez
>>>         Attachments: derby-3966-01-aa-jdbc3stubs.diff, derby-3966-01-ab-jdbc3jdbc4stubs.diff,
derby-3966-01-ac-jdbc3jdbc4stubs.diff, derby-3966-02-aa-buildTools.diff
>>>
>>>
>>> In the "JDK 1.4 support" conversation at Derby Users:
>>> http://www.nabble.com/JDK-1.4-support--td20650279.html
>>> I made a point that JRE 1.4 should not be required for build since SUN's JRE
1.4 went End Of Life.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
> I saw a build failure in the tinderbox. Is that related to your change?

It looks like the failure only happens with Ant 1.6.x, not with Ant
1.7.x. It looks like the stubs are compiled before ${empty} has been
created, and when the stubs set boot classpath to ${empty}, Ant 1.6.x
still treats it as an empty boot classpath, whereas Ant 1.7.x sees that
it doesn't exist, removes the boot classpath setting, and thereby faults
in the default boot classpath.

Ant 1.6.x therefore (correctly) compiles against the JDK 1.4 libraries,
and (correctly) fails because the stubs use StringBuilder, which is not
part of JDK 1.4. Ant 1.7.x doesn't fail, because the default classpath
that it faults in is the one of the JDK we're compiling with, which is
at least at version 1.5.

-- 
Knut Anders

Mime
View raw message