db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-1465) NetworkServerControl.start() should throw an exception and not just print exceptions if the server fails to start
Date Wed, 12 Nov 2008 23:37:44 GMT

     [ https://issues.apache.org/jira/browse/DERBY-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren updated DERBY-1465:
--------------------------------------

    Attachment: DERBY-1465.diff3

I'm attaching a patch for this issue...
It's basically Kathey's latest patch, but with the synchronization changes suggested by Dan,
and the Thread has been made a daemon thread.
There's also some extra comments.

I tried to make DRDAServerStarter.boot carry an extra parameter, and based on that parameter,
exceptions got thrown as well as logged, but the exception in the test (NSinSameJVMTest fixture
testShutdown has a new test case) came from DRDAServerStarter.run (invocationException), which
did not allow me to throw a standard exception. Also, I felt the code got more convoluted
and expansive.

Anyone have another suggestion on how to fix this, or how Dan's comment ("maybe the code could
be slightly modified to use the old thread") could be interpreted?

> NetworkServerControl.start() should throw an exception and not just  print  exceptions
 if the server fails to start
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1465
>                 URL: https://issues.apache.org/jira/browse/DERBY-1465
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server
>    Affects Versions: 10.1.2.1
>            Reporter: Kathey Marsden
>            Priority: Minor
>         Attachments: DERBY-1465.diff3, DERBY-1465_diff.txt, DERBY-1465_diff.txt, DERBY-1465_stat.txt,
DERBY-1465_stat.txt, releaseNote.html
>
>
> NetworkServerControl.start()  will not throw an exception  if another server is already
running on the same port.    I am not sure but think perhaps this was changed at  one point
to accomodate the derby.drda.startNetworkServer property  so that the embedded server could
continue to boot even if the network server failed to start, but  I think this is wrong for
normal usage.
> http://www.nabble.com/Questions-about-Network-Server-API-Behavior-p5055814.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message