db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3956) Remove method TemplateRow.checkPartialColumnTypes
Date Wed, 19 Nov 2008 10:21:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648966#action_12648966
] 

Knut Anders Hatlen commented on DERBY-3956:
-------------------------------------------

The patch looks good to me. The alternative is to enable the check and
base it on checkColumnTypes(). But I'm fine with removing it since
it's of no value in its current shape.

> Remove method TemplateRow.checkPartialColumnTypes
> -------------------------------------------------
>
>                 Key: DERBY-3956
>                 URL: https://issues.apache.org/jira/browse/DERBY-3956
>             Project: Derby
>          Issue Type: Task
>          Components: Store
>    Affects Versions: 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Trivial
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3956-1a.diff
>
>
> The method TemplateRow.checkPartialColumnTypes is only called from withing debug blocks,
and it always return true.
> I suggest the method is removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message