db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3923) Make the datatype optional when declaring columns with generation clauses
Date Fri, 14 Nov 2008 20:09:44 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Rick Hillegas updated DERBY-3923:

    Attachment: derby-3923-01-aa-optionalDatatype.diff

Attaching derby-3923-01-aa-optionalDatatype.diff. This patch makes the datatype declaration
optional for generated columns, per the functional spec for DERBY-481. Running tests now.

Touches the following files:

M      java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
M      java/engine/org/apache/derby/loc/messages.xml
M      java/shared/org/apache/derby/shared/common/reference/SQLState.java

Changes the grammar. The grammar changes mean that, for non-generated columns, we have to
proscribe the absence of a datatype during bind() rather than during parse().

M      java/engine/org/apache/derby/impl/sql/compile/AlterTableNode.java
M      java/engine/org/apache/derby/impl/sql/compile/ColumnDefinitionNode.java
M      java/engine/org/apache/derby/impl/sql/compile/CreateTableNode.java
M      java/engine/org/apache/derby/impl/sql/compile/TableElementList.java

Disables the early coercions for UDTs and collations when applied to generated columns. Instead,
moves these coercions into the logic which binds and validates generated columns--at that
time we have enough information to bind the generation clause and determine its datatype.

M      java/testing/org/apache/derbyTesting/functionTests/tests/lang/GeneratedColumnsTest.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/lang/GeneratedColumnsHelper.java

Adds tests.

> Make the datatype optional when declaring columns with generation clauses
> -------------------------------------------------------------------------
>                 Key: DERBY-3923
>                 URL: https://issues.apache.org/jira/browse/DERBY-3923
>             Project: Derby
>          Issue Type: Task
>          Components: SQL
>    Affects Versions:
>            Reporter: Rick Hillegas
>         Attachments: derby-3923-01-aa-optionalDatatype.diff
> According to the ANSI/ISO spec, the datatype is supposed to be optional for columns defined
by generation clauses. This elegant shorthand is a stretch goal.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message