db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DERBY-3902) some messages are referenced but never used - MessageBundleTest output
Date Tue, 14 Oct 2008 01:23:44 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren resolved DERBY-3902.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.5.0.0
         Assignee: Myrna van Lunteren

I addressed this by:
- moving J107, J108 and J109 to common.reference.MessageId.
  It seemed to me that there were no benefits from having them in the classes where they 
  were used, and logically, they belong with the rest of the constant message ids.
- removed 08000.S.1.
  Embedded throws error CANNOT_CLOSE_ACTIVE_CONNECTION (25001 - Cannot close a connection
while a transaction is still active) in the similar situation, so it seemed better to leave
this as is and remove the remove 08000.S.1 from messages.xml and the messages properties files.
- removed XJ102
  The current message XJ121 refers to the cursor position - I think that's preferred over
clarifying that it's an insert that fails (which is likely clear from the end-user's actions).

> some messages are referenced but never used - MessageBundleTest output
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3902
>                 URL: https://issues.apache.org/jira/browse/DERBY-3902
>             Project: Derby
>          Issue Type: Bug
>    Affects Versions: 10.5.0.0
>            Reporter: Myrna van Lunteren
>            Assignee: Myrna van Lunteren
>             Fix For: 10.5.0.0
>
>
> MessageBundleTest was taken out of derbyall because it only ran with classes, not with
jars, and it was decided that it would be better to make this into a build check rather than
a test...
> However, the build check - DERBY-1458 - was never implemented, and so, the test has not
been run.
> When I ran, I got the following output:
> testSQLStateOrphanedIds ERROR: Message id 22003.S.4 in SQLState.java was not found in
messages_en.properties
> ERROR: Message id XCL32.S in SQLState.java was not found in messages_en.properties
> ERROR: Message id X0RQ3.C in SQLState.java was not found in messages_en.properties
> ERROR: Message id XSAX1 in SQLState.java was not found in messages_en.properties
> used 188 ms .
> testMessageIdOrphanedIds used 0 ms .
> testMessageBundleOrphanedMessages WARNING: Message id 22004.S.4 in messages_en.properties
is not referenced in either SQLState.java or MessageId.java
> WARNING: Message id J106 in messages_en.properties is not referenced in either SQLState.java
or MessageId.java
> WARNING: Message id J107 in messages_en.properties is not referenced in either SQLState.java
or MessageId.java
> WARNING: Message id J108 in messages_en.properties is not referenced in either SQLState.java
or MessageId.java
> WARNING: Message id J109 in messages_en.properties is not referenced in either SQLState.java
or MessageId.java
> WARNING: Message id 08000.S.1 in messages_en.properties is not referenced in either SQLState.java
or MessageId.java
> WARNING: Message id XCL17.S in messages_en.properties is not referenced in either SQLState.java
or MessageId.java
> WARNING: Message id XJ102.S in messages_en.properties is not referenced in either SQLState.java
or MessageId.java
> used 0 ms 
> Some of these are known issues, e.g. XCL32 - it's been in MessageBundleTest.out for a
long time...
> XSAX1 looks like a assumption mismatch in MessageBundleTest, see DERBY-1413....
> But others need some minor code changes/cleanup, for instance, looks like the need for
J106 was removed during DERBY-2692, see http://svn.apache.org/viewvc?view=rev&revision=543428,
and should probably get removed from messages_en.properties/messages.xml.
> Needs further checking.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message