db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3905) Failed tests should save the database off to the fail directory
Date Mon, 13 Oct 2008 17:22:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639121#action_12639121
] 

Kathey Marsden commented on DERBY-3905:
---------------------------------------

With the old method of throwing the exception from the finally block I got a warning in Eclipse.
"finally block does not complete normally" so this was the reason I changed it.  I read a
little about the dangers of having a return statement or throwing an exception in a finally
block at:
http://www.basilv.com/psd/blog/2007/a-tale-of-bad-exception-handling-in-finally-blocks-in-java

so concluded it was probably not a good idea to keep the exception thrown in the finally block.
Do you think it is safe/a good idea  to change it back?





> Failed tests should save the database off to the fail directory
> ---------------------------------------------------------------
>
>                 Key: DERBY-3905
>                 URL: https://issues.apache.org/jira/browse/DERBY-3905
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-3905_diff.txt
>
>
> Currently failed tests save the derby.log to the fail directory for that test.  It would
be useful to save the database as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message