db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-1458) Add MessageBundleTest to build script to verify that there are no orphaned message ids
Date Thu, 16 Oct 2008 21:00:45 GMT

     [ https://issues.apache.org/jira/browse/DERBY-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren updated DERBY-1458:
--------------------------------------

    Attachment: DERBY-1458_3.diff
                DERBY-1458_3.stat

Third attempt.
I did away with the junit run and junit checks in build.xml, and instead, "svn move"d the
MessageBundleTest from the functionTests to java/build/org/apache/derbyBuild, adjusted it:
- no longer inherit from TestCase
- removed constructor
- added a main method that calls the 3 'tests'
- changed the 'ERROR' strings to 'WARNING'.
- and adjusted the package & comment.
This org.apache.derbyBuild.MessageBundleTest runs as a java task - I don't think it's needed
to have checks for this because we already have several other java tasks in the build.
Also removed the old null-ish master

This check will not cause the build to fail, just issues a warning.

The output now  looks for instance:
if all ok:
------------------
runmessagecheck:
------------------
if something missing from SQLState (or MessageId)(note that clobber & rebuild would also
catch those):
------------------
runmessagecheck:
     [java] WARNING: Message id XCL30.S in messages_en.properties is not referenced in either
SQLState.java or MessageId.java
------------------
if something's missing from messages.xml:
------------------
runmessagecheck:
     [java] ERROR: Message id XCL30.S in SQLState.java was not found in messages_en.properties
------------------



> Add MessageBundleTest to build script to verify that there are no orphaned message ids
> --------------------------------------------------------------------------------------
>
>                 Key: DERBY-1458
>                 URL: https://issues.apache.org/jira/browse/DERBY-1458
>             Project: Derby
>          Issue Type: Test
>          Components: Build tools
>    Affects Versions: 10.2.1.6
>            Reporter: David Van Couvering
>            Assignee: Myrna van Lunteren
>             Fix For: 10.5.0.0
>
>         Attachments: DERBY-1458.diff, DERBY-1458.diff2, DERBY-1458_3.diff, DERBY-1458_3.stat
>
>
> MessageBundleTest can't be run with the regular tests because it relies on SQLState.java
and MessageId.java, which are not in the jar files.  But it actually makes more sense to run
it as part of the build, as we are verifying the consistency of code references.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message