db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-1458) Add MessageBundleTest to build script to verify that there are no orphaned message ids
Date Wed, 15 Oct 2008 21:52:44 GMT

     [ https://issues.apache.org/jira/browse/DERBY-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren updated DERBY-1458:
--------------------------------------

    Attachment: DERBY-1458.diff2

I assume that the problem with the tinderbox was that ant does not have the optional package
installed that gives the junit task (ant-junit.jar).
I had the choice to either make the messagebundle check depend on whether or not the junit
task was available, or to create a taskdef, or antcall, to do the same as the junit-single
target, but not use the "junit" task.

I chose to continue to rely on the existing junit task, having two things to do essentially
the same seemed rather ugly.
It does make the check a little less useful (as not run everywhere, or by everyone).

I'm attaching a patch that makes ant all:
- check for the optional junit package
- if the junit task is not available, print a message indicating no message check is getting
run.
- else run the messagebundletest
- remove the junit test dir. All interesting info should be visible in the build output.

output if ant-junit.jar is available is now:
-----------------------------
checkjunittask:

junit-init:
    [mkdir] Created dir: <mytrunkdir>\junit_20081015_1448\testout

runmessagechecktest:

junit-init:

junit-single:
    [junit] Running org.apache.derbyTesting.functionTests.tests.i18n.MessageBundleTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.172 sec

cleanjunit:
   [delete] Deleting directory <mytrunkdir>\junit_20081015_1448

nojunittask:

runmessagecheck:
-----------------------------
if not available:
-----------------------------
junit-init:
    [mkdir] Created dir: <mytrunkdir>\junit_20081015_1433\testout

runmessagechecktest:

nojunittask:
     [echo] no junit task available; no message check run

cleanjunit:
   [delete] Deleting directory <mytrunkdir>\junit_20081015_1433

runmessagecheck:
-----------------------------

I'll wait for comments for a day or so.

> Add MessageBundleTest to build script to verify that there are no orphaned message ids
> --------------------------------------------------------------------------------------
>
>                 Key: DERBY-1458
>                 URL: https://issues.apache.org/jira/browse/DERBY-1458
>             Project: Derby
>          Issue Type: Test
>          Components: Build tools
>    Affects Versions: 10.2.1.6
>            Reporter: David Van Couvering
>            Assignee: Myrna van Lunteren
>             Fix For: 10.5.0.0
>
>         Attachments: DERBY-1458.diff, DERBY-1458.diff2
>
>
> MessageBundleTest can't be run with the regular tests because it relies on SQLState.java
and MessageId.java, which are not in the jar files.  But it actually makes more sense to run
it as part of the build, as we are verifying the consistency of code references.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message