Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Date: Tue, 02 Sep 2008 10:36:46 +0200
From: Kristian Waagan <Kristian.Waagan@Sun.COM>
Subject: Re: Help with build.xml so that DataDictionary class will compile
 with
 jdk1.5 and higher...
In-reply-to: <d9619e4a0809012326o13841549q7d850fe270c69cd2@mail.gmail.com>
Sender: Kristian.Waagan@Sun.COM
To: derby-dev@db.apache.org
Message-id: <48BCFB1E.7010309@Sun.com>
Organization: Sun Microsystems Inc.
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
References: <d9619e4a0808291145x4b032ffclefe74b86ccda0930@mail.gmail.com>
 <48B84B59.6080709@sun.com>
 <d9619e4a0808291317v59c48dbbn1516b491d77920c5@mail.gmail.com>
 <48B85AF2.4010805@sun.com>
 <d9619e4a0808291337y50cfe005n1959fb043cebaf3b@mail.gmail.com>
 <48B86291.1090900@sun.com>
 <d9619e4a0809012326o13841549q7d850fe270c69cd2@mail.gmail.com>
User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; no-NO; rv:1.8.1.14)
 Gecko/20080714 Lightning/0.8 Thunderbird/2.0.0.14 Mnenhy/0.7.5.0

On 09/02/08 08:26, Mamta Satoor wrote:
> Hi Rick,
> 
> You are right, I did have typo in my build,xml file. I have fixed that
> and I think simplified the build,xml more than what I had last Friday
> but I still continue to get build errors about missing
> java.util.concurrent. package.

Hi Mamta,

I haven't looked into this, but earlier it has been a problem that when 
you compile classes with a lower version of Java, the build system might 
pull in dependencies (other classes) that require a higher version of 
Java. The order of the build targets can be of importance in this case.

Have you investigated if this can be what happens for you?
Can you identify under which build target the failure is happening?


regards,
-- 
Kristian

> 
> The latest build.xml is attached.
> 
> thanks,
> Mamta
> 
> On 8/29/08, Rick Hillegas <Richard.Hillegas@sun.com> wrote:
>> Hi Mamta,
>>
>> One think that looks odd to me in the build.xml from your original post is
>> this: you are exluding
>> ${derby.dir}/iapi/sql/DataDictionary.java. I think you may
>> mean to exclude
>> ${derby.dir}/iapi/sql/dictionary/DataDictionary.java
>>
>>
>> Hope this helps,
>> -Rick
>>
>> Mamta Satoor wrote:
>>>    [javac]
>> C:\p4clients\svnmain\client1\trunk\java\engine\org\apache\derby\iapi\sql\dictionary\DataDictionary.java:52:
>>> package java.util.concurrent does not exist
>>>    [javac] import
>> java.util.concurrent.ThreadPoolExecutor;
>>>    [javac]                            ^
>>>    [javac] 1 error
>>>
>>> thanks,
>>> Mamta
>>>
>>> On 8/29/08, Rick Hillegas <Richard.Hillegas@sun.com> wrote:
>>>
>>>
>>>> Hi Mamta,
>>>>
>>>> What error are you seeing?
>>>>
>>>> -Rick
>>>>
>>>>
>>>> Mamta Satoor wrote:
>>>>
>>>>
>>>>> Thanks for your reply, Rick. I changed my build.xml as shown in the
>>>>> attached file and still no luck yet :(
>>>>>
>>>>> Mamta
>>>>>
>>>>> On 8/29/08, Rick Hillegas <Richard.Hillegas@sun.com> wrote:
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> Hi Mamta,
>>>>>>
>>>>>> Here's a target from java/demo/build.xml which compiles some classes
>>>>>>
>>>>>>
>>>> with
>>>>
>>>>
>>>>>> the 1.5 compiler. This may work better for you:
>>>>>>
>>>>>>  <target name="compile-vtidemo">
>>>>>>  <javac
>>>>>>   source="1.5"
>>>>>>   target="1.5"
>>>>>>   bootclasspath="${empty}"
>>>>>>   nowarn="on"
>>>>>>   debug="${debug}"
>>>>>>   depend="${depend}"
>>>>>>   deprecation="${deprecation}"
>>>>>>   optimize="${optimize}"
>>>>>>   proceed="${proceed}"
>>>>>>   verbose="${verbose}"
>>>>>>   srcdir="${derby.demo.src.dir}/vtis/java"
>>>>>>   destdir="${out.dir}">
>>>>>>   <classpath>
>>>>>>     <pathelement
>> path="${java15compile.classpath}"/>
>>>>>>   </classpath>
>>>>>>    <!-- <compilerarg value="-Xlint:unchecked"/> -->
>>>>>>  </javac>
>>>>>>  </target>
>>>>>>
>>>>>> Hope this helps,
>>>>>> -Rick
>>>>>>
>>>>>>
>>>>>> Mamta Satoor wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I am adding an import of
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> java.util.concurrent.ThreadPoolExecutor in
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>> org.apache.derby.iapi.sql.dictionary.DataDictionary
>>>>>>>
>>>> and
>>>>
>>>>
>>>>>>>
>>>>>> when I compile
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> it without any changes to build.xml, I ofcourse get errors for
>> that
>>>>>>> import because it is only available in jdk1.5 and higher.
>>>>>>>
>>>>>>> In order to fix this, I have made changes to
>>>>>>> org.apache.derby.iapi.sql.build.xml (attached to
>> this
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> mail) so that
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> DataDictionary is excluded from compile with jdk1.4 and will be
>>>>>>> compiled with jdk1.6 But that is not fixing the problem. I was
>>>>>>> wondering if someone more familiar with build.xml can help me on
>> this?
>>>>>>> This is my first time trying to add a new target and my attempt at
>>>>>>> changes in this build.xml are based on other build.xmls in the
>> Derby
>>>>>>> engine code.
>>>>>>>
>>>>>>> thanks,
>>>>>>> Mamta
>>>>>>> ps this is a temporary thing to put something jdk1.5 specific in
>>>>>>> DataDictionary. I later plan subclass it and then jdk1.5 specific
>>>>>>> stuff will go into that new class. But I will have to go through
>> the
>>>>>>> same exercise of changing build,xml for that new file and hence
>> this
>>>>>>> exercise of changing the build.xml will be useful later.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>
>>