Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <335715175.1220636566076.JavaMail.jira@brutus>
Date: Fri, 5 Sep 2008 10:42:46 -0700 (PDT)
From: "Knut Anders Hatlen (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Updated: (DERBY-3850) Remove unneeded workarounds for
 DERBY-177 and DERBY-3693
In-Reply-To: <1016381140.1219680584269.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen updated DERBY-3850:
--------------------------------------

    Derby Info:   (was: [Patch Available])

Thanks for looking at the patch, Bryan!

You're right about the removal of 'colsToUpdate'. That variable was declared and never used, so I felt that I could just as well remove it together with 'wait' while I was cleaning up that method.

Committed revision 692495.

The comments around the wait parameters said they were introduced to fix bug 4821. There are other places in the code that mention this bug too, and that add wait parameters to method signatures. I'll take a look at them and see if cleanup is needed there as well and if the new mechanism to prevent waiting could be used instead of the wait flags.

There is also one occurrence in the tests, in lang/predicatesIntoViews.sql:

-- if we don't commit, the following insert will block due to fix of beetle 4821
commit;

-- The following insert statement shouldn't block for 2 minutes!! The compile of the trigger
-- shouldn't wait for timeout!!

I'll check if this still is a problem.

> Remove unneeded workarounds for DERBY-177 and DERBY-3693
> --------------------------------------------------------
>
>                 Key: DERBY-3850
>                 URL: https://issues.apache.org/jira/browse/DERBY-3850
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL, Test
>    Affects Versions: 10.5.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d3850-test.diff, d3850-wait.diff, d3850-wait.stat
>
>
> After the fix for DERBY-177 and DERBY-3693 was committed, these code clean-ups could be performed:
>   - remove workaround for DERBY-177 in the tests (search for the string "DERBY-177" to find them)
>   - remove logic to prevent waiting for table locks in SPSDescriptor.updateSYSSTATEMENTS() since the new mechanism will prevent waiting for all types of locks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.