Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 68618 invoked from network); 22 Sep 2008 18:05:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Sep 2008 18:05:06 -0000 Received: (qmail 57190 invoked by uid 500); 22 Sep 2008 18:05:02 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 57161 invoked by uid 500); 22 Sep 2008 18:05:02 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 57150 invoked by uid 99); 22 Sep 2008 18:05:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2008 11:05:02 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2008 18:04:11 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6854F234C1E3 for ; Mon, 22 Sep 2008 11:04:44 -0700 (PDT) Message-ID: <238988823.1222106684426.JavaMail.jira@brutus> Date: Mon, 22 Sep 2008 11:04:44 -0700 (PDT) From: "Kim Haase (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-3874) Document numeric function ATAN2(float1,float2) In-Reply-To: <235601025.1221120704350.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633408#action_12633408 ] Kim Haase commented on DERBY-3874: ---------------------------------- I can document this, but I have a few questions. 1) The javadoc for atan reports only a couple of odd cases, for values of NaN or zero. The Ref Manual documentation for atan has similar odd cases, for NULL and zero. The javadoc for atan2, on the other hand, has a whole lot of odd cases for various values of the two arguments. Should they all be mentioned, and should it be obvious how these translate? (I have documented floating-point functions before so I'm not entirely at sea here ...) 2) I notice that the file java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/DatabaseMetaDataTest.java has exactly one atan2 test, for a normal set of values. This file also has just one test for atan. However, the file java/testing/org/apache/derbyTesting/functionTests/tests/lang/MathTrigFunctionsTest.java has some reasonably extensive testing for atan, but none at all for atan2. Does it make sense to document this function when it isn't thoroughly tested yet? > Document numeric function ATAN2(float1,float2) > ---------------------------------------------- > > Key: DERBY-3874 > URL: https://issues.apache.org/jira/browse/DERBY-3874 > Project: Derby > Issue Type: Sub-task > Components: Documentation > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > > Document the numeric function ATAN2(float1,float2). > Mentioned in the JDBC specification, appendix C.1. > Implementation documented by the JavaDoc for StrictMath.atan2. > According to the JDBC specification, table B-1, a JDBC float maps to a Java double. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.