db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3850) Remove unneeded workarounds for DERBY-177 and DERBY-3693
Date Fri, 05 Sep 2008 07:59:44 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-3850:
--------------------------------------

    Attachment: d3850-wait.stat
                d3850-wait.diff

Here's a patch (d3850-wait.diff) that removes the wait parameter from some methods used by
SPSDescriptor.updateSYSSTATEMENTS(). The wait parameter was passed further down by those methods
too, so a number of classes had to be touched. I've done my best to trace the callers of these
methods, and as far as I could see, wait was always true when the calls didn't come from the
code that we changed in DERBY-3693 to use a different mechanism to prevent waiting. So it
looks safe to me to remove the wait flag and use timed waits in these methods.

> Remove unneeded workarounds for DERBY-177 and DERBY-3693
> --------------------------------------------------------
>
>                 Key: DERBY-3850
>                 URL: https://issues.apache.org/jira/browse/DERBY-3850
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL, Test
>    Affects Versions: 10.5.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d3850-test.diff, d3850-wait.diff, d3850-wait.stat
>
>
> After the fix for DERBY-177 and DERBY-3693 was committed, these code clean-ups could
be performed:
>   - remove workaround for DERBY-177 in the tests (search for the string "DERBY-177" to
find them)
>   - remove logic to prevent waiting for table locks in SPSDescriptor.updateSYSSTATEMENTS()
since the new mechanism will prevent waiting for all types of locks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message