db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3850) Remove unneeded workarounds for DERBY-177 and DERBY-3693
Date Wed, 10 Sep 2008 09:38:44 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Knut Anders Hatlen updated DERBY-3850:
--------------------------------------

    Attachment: d3850-tabinfo.diff

Attaching a new patch (d3850-tabinfo.diff) that removes the wait parameter from TabInfoImpl.updateRow().
The method only had two callers, both of which called it with wait=true. updateRow() passed
the parameter on to RowChanger.openForUpdate(), but that method is sometimes called with wait=false,
so I couldn't remove the parameter from that method.

The patch also removes an unused variable in the method and some unused import statements.

Derbyall and suites.All passed.

> Remove unneeded workarounds for DERBY-177 and DERBY-3693
> --------------------------------------------------------
>
>                 Key: DERBY-3850
>                 URL: https://issues.apache.org/jira/browse/DERBY-3850
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL, Test
>    Affects Versions: 10.5.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d3850-predicatesIntoViews.diff, d3850-predicatesIntoViews.stat,
d3850-tabinfo.diff, d3850-test.diff, d3850-wait.diff, d3850-wait.stat
>
>
> After the fix for DERBY-177 and DERBY-3693 was committed, these code clean-ups could
be performed:
>   - remove workaround for DERBY-177 in the tests (search for the string "DERBY-177" to
find them)
>   - remove logic to prevent waiting for table locks in SPSDescriptor.updateSYSSTATEMENTS()
since the new mechanism will prevent waiting for all types of locks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message