db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jørgen Løland (JIRA) <j...@apache.org>
Subject [jira] Created: (DERBY-3878) Replication: stopSlave does not close serversocket when master has crashed.
Date Tue, 16 Sep 2008 11:52:44 GMT
Replication: stopSlave does not close serversocket when master has crashed.
---------------------------------------------------------------------------

                 Key: DERBY-3878
                 URL: https://issues.apache.org/jira/browse/DERBY-3878
             Project: Derby
          Issue Type: Bug
          Components: Replication
    Affects Versions: 10.4.2.0
            Reporter: Jørgen Løland


The stopSlave command (connection URL attribute) fails to close the ServerSocket when called
after master database has crashed. Because of this, the same Derby instance cannot later start
a slave on the same port. 

The problem is in ReplicationMessageReceive#tearDown and SocketConnection#tearDown:

SC#tearDown:
When objOutputStream is closed, the stream's flush method is called. Flush throws an exception,
and socket.close is not called.

RMR#tearDown:
When socketCon.teardown throws an exception, serverSocket.close is not called.

Suggested fix: add try/catch/finally blocks so that vital code (socket.close and serverSocket.close)
is always called.

Note that the stop slave command can also come from the master (if stopMaster connection URL
is called), in which case this bug will not materialize.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message