db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Pendleton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3850) Remove unneeded workarounds for DERBY-177 and DERBY-3693
Date Fri, 05 Sep 2008 14:44:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628643#action_12628643
] 

Bryan Pendleton commented on DERBY-3850:
----------------------------------------

Hi Knut, thanks for following up with this cleanup. I read through the diff and
it looks great to me; it is very nice to be able to accomplish all this simplification
and removal of that awkward 'wait' parameter throughout all that code.

The only thing I noticed was the removal of the 'colsToUpdate' variable
in SPSDescriptor.java -- was that just an opportunistic removal of an
unrelated unused variable? If so, seems fine to me, I only noticed it
because it didn't seem related to the rest of the changes.

I didn't build or run any tests, just read the diff, but it looks fine to me, +1.


> Remove unneeded workarounds for DERBY-177 and DERBY-3693
> --------------------------------------------------------
>
>                 Key: DERBY-3850
>                 URL: https://issues.apache.org/jira/browse/DERBY-3850
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL, Test
>    Affects Versions: 10.5.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: d3850-test.diff, d3850-wait.diff, d3850-wait.stat
>
>
> After the fix for DERBY-177 and DERBY-3693 was committed, these code clean-ups could
be performed:
>   - remove workaround for DERBY-177 in the tests (search for the string "DERBY-177" to
find them)
>   - remove logic to prevent waiting for table locks in SPSDescriptor.updateSYSSTATEMENTS()
since the new mechanism will prevent waiting for all types of locks

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message