db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3063) Extend the system function mechanism to support functions with multiple arguments
Date Fri, 05 Sep 2008 13:49:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628631#action_12628631
] 

Knut Anders Hatlen commented on DERBY-3063:
-------------------------------------------

Hi Kristian,

Sorry for the very late reply. The approach in the patch looks reasonable to me, and I don't
think it makes the code more complex or harder to read. With your changes, the code could
potentially be made even simpler, since there is no longer any reason to have a special case
for the functions without parameters. So in DataDictionaryImpl.getRoutineList() the "if (paramCount>0) {...}
else {...}" part could be changed to always execute the first branch regardless of the value
of paramCount.

I don't know the answer to question (b), but even if it isn't possible, it should be fairly
easy to write a static method with a matching parameter list in SystemProcedures, much the
same way as it is currently done for some of the other functions (PI, LOG10, SIGN, RAND, COT,
COSH, SINH and TANH).

> Extend the system function mechanism to support functions with multiple arguments
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-3063
>                 URL: https://issues.apache.org/jira/browse/DERBY-3063
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 10.4.1.3
>            Reporter: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-3063-1a-preview.diff, derby-3063-1a-preview.stat
>
>
> Extend the existing functionality for adding Java functions to SQL to support functions
with multiple arguments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message