Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1906549903.1219773404243.JavaMail.jira@brutus>
Date: Tue, 26 Aug 2008 10:56:44 -0700 (PDT)
From: "Mamta A. Satoor (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-3842) Convert
 "org.apache.derbyTesting.functionTests.tests.store.holdCursorExternalSortJDBC30.sql"
 to junit.
In-Reply-To: <627133149.1218961666394.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625807#action_12625807 ] 

Mamta A. Satoor commented on DERBY-3842:
----------------------------------------

Thanks for working on the test conversion. It looks pretty good. Just couple more comments. 
1)I think it would be good to drop the table foo at the end of fixture testOrderWthMultipleLevel
2)Also, like with the other hold cursor tests, I am not sure if it is enough to check the row number after doing a "next" or if we should actually be looking at the actual data returned.

> Convert "org.apache.derbyTesting.functionTests.tests.store.holdCursorExternalSortJDBC30.sql" to junit.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3842
>                 URL: https://issues.apache.org/jira/browse/DERBY-3842
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>         Attachments: derby-3842-1.patch, derby-3842-1.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.