Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <1343436983.1218739544343.JavaMail.jira@brutus>
Date: Thu, 14 Aug 2008 11:45:44 -0700 (PDT)
From: "Myrna van Lunteren (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-3829) Convert derbynet/sysinfo and
 derbynet/sysinfo_with_properties to JUnit
In-Reply-To: <674162625.1218388305853.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622637#action_12622637 ] 

Myrna van Lunteren commented on DERBY-3829:
-------------------------------------------

Looks mostly ok, however I got 5 failures when I ran the test (with classes), and I think the main cause is this:
testSysinfoMethod(org.apache.derbyTesting.functionTests.tests.derbynet.SysinfoTest)java.lang.Exception: DRDA_InvalidReplyTooShort.S:Invalid reply from network server: Insufficient data.

I see you've used BufferedOutputStream and ExecProcUtil.execCmdDumpResults(SysInfoLocaleCmd,vCmd,bos).

The ExecProcUtil is really part of the "old" test harness...

Furthermore, what comes through the buffer may not always be the same, or the full output. That's why we used an InputStreamReader with the BaseTestCase.assertExecJavaCmdAsExpected.


> Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3829
>                 URL: https://issues.apache.org/jira/browse/DERBY-3829
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Erlend Birkenes
>            Assignee: Erlend Birkenes
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: Derby-3829_1.diff
>
>
> I'm guessing these two can be combined into one file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.