Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 82368 invoked from network); 26 Aug 2008 07:38:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Aug 2008 07:38:38 -0000 Received: (qmail 99696 invoked by uid 500); 26 Aug 2008 07:38:35 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 99536 invoked by uid 500); 26 Aug 2008 07:38:35 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 99488 invoked by uid 99); 26 Aug 2008 07:38:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Aug 2008 00:38:35 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Aug 2008 07:37:44 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8F87B234C1B2 for ; Tue, 26 Aug 2008 00:37:44 -0700 (PDT) Message-ID: <1303056409.1219736264586.JavaMail.jira@brutus> Date: Tue, 26 Aug 2008 00:37:44 -0700 (PDT) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-3731) Improve calculation of refSize in ClassSize.java In-Reply-To: <1481704965.1213911705179.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625656#action_12625656 ] Kristian Waagan commented on DERBY-3731: ---------------------------------------- The 1c patch hasn't been ported to 10.4, nor 10.3. I don't think the patch has caused any serious problems on trunk. With the patch, refSize is more likely to be correct. The following tasks remain: a) Document the required privileges. b) Add the privileges to the template policy file. The permissions to read the properties are not mandatory. If they are missing, the old heuristic will be used. > Improve calculation of refSize in ClassSize.java > ------------------------------------------------- > > Key: DERBY-3731 > URL: https://issues.apache.org/jira/browse/DERBY-3731 > Project: Derby > Issue Type: Bug > Components: SQL > Affects Versions: 10.5.0.0 > Reporter: Kathey Marsden > Assignee: Kristian Waagan > Priority: Minor > Fix For: 10.4.2.0, 10.5.0.0 > > Attachments: derby-3731-1a-refsize_from_properties.diff, derby-3731-1b-refsize_from_properties.diff, derby-3731-1b-refsize_from_properties.stat, derby-3731-1c-refsize_from_properties.diff, DERBY-3731_diff.txt > > > java/engine/org/apache/derby/iapi/services/cache/ClassSize.java has a static code block which calculates the size of a reference for the architecture. This code could be improved by adding garbage collection before measuring memory, to give a consistent reading. Also there have been suggestions that we use os.arch or sun.arch.data.model to make the measurement more reliable, especially on 64bit machines. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.