Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 43778 invoked from network); 27 Aug 2008 13:45:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Aug 2008 13:45:06 -0000 Received: (qmail 5087 invoked by uid 500); 27 Aug 2008 13:44:53 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 5038 invoked by uid 500); 27 Aug 2008 13:44:53 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 4859 invoked by uid 99); 27 Aug 2008 13:44:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Aug 2008 06:44:53 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Aug 2008 13:44:03 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5EC8F234C1B4 for ; Wed, 27 Aug 2008 06:43:44 -0700 (PDT) Message-ID: <1120285494.1219844624387.JavaMail.jira@brutus> Date: Wed, 27 Aug 2008 06:43:44 -0700 (PDT) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-3601) Optimize LOBStateTracker for non-locator servers In-Reply-To: <113638881.1207564824478.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3601: ----------------------------------- Derby Info: [Patch Available] > Optimize LOBStateTracker for non-locator servers > ------------------------------------------------ > > Key: DERBY-3601 > URL: https://issues.apache.org/jira/browse/DERBY-3601 > Project: Derby > Issue Type: Improvement > Components: Network Client, Newcomer > Affects Versions: 10.4.1.3, 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Trivial > Attachments: derby-3601-1a-comments_and_renaming.diff > > > The following comments posted for DERBY-3571 should be addressed if we choose to allow multiple calls to the various getter methods on LOB columns, except for the getter methods returning streams: > ----- Knut Anders wrote: > 've tried out the 2a patch and it seems to work as intended. My only nits are: > - LOBStateTracker.checkCurrentRow(): couldn't Arrays.fill() be moved inside the if block? > - should discardState() and markAccessed() check the release flag? > - should ResultSet.createLOBColumnTracker() use LOBStateTracker.NO_OP_TRACKER instead of allocating a new when serverSupportsLocators() returns false? > ----- > Note that it is a requirement that we allow multiple calls to the getter methods, otherwise we need to maintain the state for non-locator LOB columns as well to track the number of accesses. Another options is to rely on a different mechanism to track accesses. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.