db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3717) convert derbynet/getCurrentProperties.java to junit
Date Thu, 07 Aug 2008 11:45:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620605#action_12620605
] 

Kristian Waagan commented on DERBY-3717:
----------------------------------------

Sorry this is taking so long, but here are some more comments on the latest patch.

 a) Is the full policy file required? It looks like a copy of the general testing policy file.
 b) The code verifying the properties doesn't look right. As far as I can see, the properties
object from NetworkServerControl is never used. This goes for all three "testXXX" methods.
 c) Since makeServerPolicyName has been made static, why instantiate GetCurrentPropertiesTest?
 d) Would it be better to fail the test if an exception is raised in makeServerPolicyName?
A fail-method taking an Exception has been added to BaseTestCase.
 e) Lots of unused imports (and some duplicate imports).

thanks,

> convert derbynet/getCurrentProperties.java to junit
> ---------------------------------------------------
>
>                 Key: DERBY-3717
>                 URL: https://issues.apache.org/jira/browse/DERBY-3717
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.1.4
>            Reporter: Manjula Kutty
>            Assignee: Manjula Kutty
>         Attachments: DERBY_3717_06_10_diff.txt, DERBY_3717_06_10_stat.txt, DERBY_3717_07_22_diff.txt,
DERBY_3717_07_22_stat.txt, DERBY_3717_07_25_diff.txt, DERBY_3717_07_25_stat.txt, DERBY_3717_diff.txt,
DERBY_3717_stat.txt
>
>
> Place holder to contribute the convered test

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message