db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rick Hillegas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3223) SQL roles: make use of privileges granted to roles in actual privilege checking
Date Tue, 26 Aug 2008 19:48:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625838#action_12625838
] 

Rick Hillegas commented on DERBY-3223:
--------------------------------------

Thanks for the patch, Dag. I have a couple comments, mostly related to the switch statements
which filter out useful invalidation reasons:

BaseActivation.makeInvalid(): To my eyes there is only one case in this switch
statement which does anything. Are the other cases performing some
useful work? There's a similar, long switch statement in
ConstraintDescriptor.prepareToInvalidate(), which I noticed you had to
touch. Was that useful?

ViewDescriptor.prepareToInvalidate(). Here's another long, vacuous
switch statement which puzzles me. Is there some reason that all of
the cases fall through to the RECHECK_PRIVILEGES case except for the
INTERNAL_RECOMPILE_REQUEST case? It looks to me as though the work of
this switch statement could be accomplished by one case
(REVOKE_PRIVILEGE_RESTRICT), which raises an exception--all other
cases could exit gracefully without having to bother to name themselves.

GenericActivationHolder. I wonder what it means for this object to
have the same UUID as the Activation it holds. This UUID will not
uniquely identify an object.


> SQL roles: make use of privileges granted to roles in actual privilege checking
> -------------------------------------------------------------------------------
>
>                 Key: DERBY-3223
>                 URL: https://issues.apache.org/jira/browse/DERBY-3223
>             Project: Derby
>          Issue Type: Task
>          Components: Security, SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3223-1a.diff, derby-3223-1a.stat, derby-3223-1b.diff, derby-3223-1b.stat,
derby-3223-1c.diff, derby-3223-1c.stat, derby-3223-1d.diff, derby-3223-1d.stat, derby-3223-activate-roles-1.diff,
derby-3223-activate-roles-1.stat, derby-3223-activate-roles-2.diff, derby-3223-activate-roles-2.stat,
derby-3223-activate-roles-2b.diff, derby-3223-activate-roles-2b.stat, derby-3223-invalidate-activations-1.diff,
derby-3223-invalidate-activations-1.stat, derby-3223-revise-iterator-api-b.diff, derby-3223-revise-iterator-api-b.stat,
derby-3223-revise-iterator-api.diff, derby-3223-revise-iterator-api.stat, derby-3223-revocation-logic-1.diff,
derby-3223-revocation-logic-1.stat, derby-3223-revocation-logic-2.diff, derby-3223-revocation-logic-2.stat,
derby-3223-revocation-logic-2.txt, derby-3223-revocation-logic-3.diff, derby-3223-revocation-logic-3.stat,
derby-3223-revocation-logic-4.diff, derby-3223-revocation-logic-4.stat, derby-3223-revocation-logic-5.diff,
derby-3223-revocation-logic-5.stat, roles.sql, roles2.sql, roles3.sql
>
>
> Pushing out to 10.5

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message