db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3829) Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit
Date Wed, 20 Aug 2008 16:38:48 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren updated DERBY-3829:
--------------------------------------

    Attachment: DERBY-3829_m3.diff

I finally figured out that the problem was with the sed() method and the comparisons;
on windows, the end-of-line character is not \n, but \n\r, at least for most lines (empirically,
it seemed, the 'Version...' line has \n. But I could have been dreaming that up).
I added a replaceAll line to swap all \n\r to \n and then my problems went away.
I assume the permissions problem I saw was a result of left over policy file settings.

other modifications over previous patch:

- the new class had somehow gotten a mix of tabs and spaces. I turned it into all spaces.
- network server tests can't run with JSR169 - nor when derbynet is not available. 
  added those two conditions to the suite() method (returns empty suite if not ok).
- the code in org.apache.derbyTesting.functionTests.harness should not be used anymore, this
  includes references to the jvm class, and setting of j9_13 jvm etc.
  I took that section out.
- junit keeps state of all global variables until the entire suite (e.g. suites.All) is done.
  So, using global variables is a drain on resources.
  If it can't be avoided making a variable global, then it should get set to null in a teardown()
method.
  I took care of this
- the print variable was no longer needed but was accidentally left behind
- the makePolicyName() was doing a System.out.println. I see this is done in some other tests
(e.g.
  ServerPropertiesTest, which I converted), but we might as well make it fail, I think.

> Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3829
>                 URL: https://issues.apache.org/jira/browse/DERBY-3829
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Erlend Birkenes
>            Assignee: Erlend Birkenes
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: Derby-3829_1.diff, Derby-3829_2.diff, DERBY-3829_m3.diff
>
>
> I'm guessing these two can be combined into one file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message