db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DERBY-3798) Remove unnecessary call to Hashtable.get() in TableScanResultSet.getNextRowCore()
Date Fri, 15 Aug 2008 11:25:44 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren resolved DERBY-3798.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.5.0.0

I committed the patch with revision 686193.

> Remove unnecessary call to Hashtable.get() in TableScanResultSet.getNextRowCore()
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-3798
>                 URL: https://issues.apache.org/jira/browse/DERBY-3798
>             Project: Derby
>          Issue Type: Improvement
>          Components: Newcomer, SQL
>    Affects Versions: 10.5.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Junjie Peng
>            Priority: Trivial
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3798-1.patch, derby-3798-1.stat
>
>
> I came across this piece of code in TableScanResultSet.getNextRowCore():
> 						if (past2FutureTbl.get(rowLoc) != null)
> 						{
> 							past2FutureTbl.remove(rowLoc);
> 							continue;
> 						}
> I believe the call to Hashtable.get() is unnecessary since Hashtable.remove() returns
the object it removed or null if the key was not in the table. So I believe the code could
be simplified like this without changing the behaviour:
>     if (past2FutureTbl.remove(rowLoc) != null) {
>         continue;
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message