db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erlend Birkenes (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3829) Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit
Date Fri, 15 Aug 2008 00:03:44 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622749#action_12622749
] 

Erlend Birkenes commented on DERBY-3829:
----------------------------------------

Hmm, I don't get the permissions errors or any other errors here, seems something is different
on windows. I'll try to figure out what..

I'll change ExecProcUtil.execCmdDumpResults to something else. I could have just used BaseTestCase.assertExecJavaCmdAsExpected
if it could deal with the parts of the output that are variable.. 

Is it a good idea to extract the command-running part of  assertExecJavaCmdAsExpected into
a new method that just runs the command and returns the output? assertExecJavaCmdAsExpected
would call the new method so it would stay the same, but the output would be available for
manipulation when that's needed. That would be useful for DERBY-3824 as well. The exact same
thing is done there, so it would at least save some duplicate code. However, this is the last
two places where execCmdDumpResults is used, so maybe it's not worth messing with it..

> Convert derbynet/sysinfo and derbynet/sysinfo_with_properties to JUnit
> ----------------------------------------------------------------------
>
>                 Key: DERBY-3829
>                 URL: https://issues.apache.org/jira/browse/DERBY-3829
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Erlend Birkenes
>            Assignee: Erlend Birkenes
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: Derby-3829_1.diff
>
>
> I'm guessing these two can be combined into one file

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message