Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <2063834328.1217532153562.JavaMail.jira@brutus>
Date: Thu, 31 Jul 2008 12:22:33 -0700 (PDT)
From: "Kathey Marsden (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-3800) Convert derbynet/maxthreads to JUnit
In-Reply-To: <1188679552.1217182352493.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618819#action_12618819 ] 

Kathey Marsden commented on DERBY-3800:
---------------------------------------

Thanks Suran for the patch.

- There seem to be a lot of white space changes, not related to the patch which make it hard to read.   It would be better if the patch did not include white space changes.
- I don't think we should have a static NetworkServerControl as it never gets cleaned up. Fixtures that need it can instantiate their own NetworkServerControl.  That way too I think you can avoid making suite() throw an exception.
- testMaxThreadsInvalid can set maxthread to a valid value before trying to set it to an invalid value, so you can verify that the valid value is still set.


> Convert derbynet/maxthreads to JUnit
> ------------------------------------
>
>                 Key: DERBY-3800
>                 URL: https://issues.apache.org/jira/browse/DERBY-3800
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>            Reporter: Suran Jayathilaka
>            Assignee: Suran Jayathilaka
>         Attachments: derby-3800-1.diff
>
>
> Convert derbynet/maxthreads.java test into a JUnit testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.