Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 56453 invoked from network); 9 Jul 2008 14:43:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Jul 2008 14:43:54 -0000 Received: (qmail 91130 invoked by uid 500); 9 Jul 2008 14:43:53 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 91107 invoked by uid 500); 9 Jul 2008 14:43:53 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 91071 invoked by uid 99); 9 Jul 2008 14:43:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2008 07:43:53 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2008 14:43:09 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B9370234C15B for ; Wed, 9 Jul 2008 07:43:31 -0700 (PDT) Message-ID: <107194342.1215614611757.JavaMail.jira@brutus> Date: Wed, 9 Jul 2008 07:43:31 -0700 (PDT) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-3768) Make EmbedBlob.length use skip instead of read In-Reply-To: <604434745.1215602851680.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3768: ----------------------------------- Attachment: derby-3768-2a-misc_fixes.diff 'derby-3768-2a-misc_fixes.diff' contains a set of small fixes: - JavaDoc improvements - set locator value explicitly to indicate default value (must not be a valid locator) - renamed 'myLength' to 'streamLength' - keep variables 'materialized' and 'streamLength' in sync - throw exception in second constructor (mistakenly swallowed) - only clear LOB mapping if a mapping has been created Awaiting test run completion. Patch ready for review. > Make EmbedBlob.length use skip instead of read > ---------------------------------------------- > > Key: DERBY-3768 > URL: https://issues.apache.org/jira/browse/DERBY-3768 > Project: Derby > Issue Type: Improvement > Components: JDBC > Affects Versions: 10.5.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Minor > Fix For: 10.5.0.0 > > Attachments: derby-3768-1a-length_skip.diff, derby-3768-1b-length_skip.diff, derby-3768-2a-misc_fixes.diff > > > EmbedBlob.length uses read to process the whole Blob when the length has not been encoded at the head of the stream. > Using skip instead of read can lead to better performance. > I also plan to make some minor cleanups under this issue; JavaDoc and to rename a variable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.