db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3717) convert derbynet/getCurrentProperties.java to junit
Date Thu, 24 Jul 2008 09:03:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616388#action_12616388

Knut Anders Hatlen commented on DERBY-3717:

I think some of the previous comments are still unaddressed.

  - The try/catch/print code should be removed. Instead, the methods should be declared as
"throws Exception" so that the JUnit framework picks up and reports the errors correctly.

  - We cannot rely on the ordering of the elements in the Properties object.

  - The indentation still looks strange.

  - Could makeServerPolicyName() be made static so that decorateWithPolicy() 

  - In all the test methods, element 0 of expectedValues is set in the for loop which compares
the actual values with the expected values. Why not set element 0 to the correct value when
expectedValues is initialized?

  - Should the test also be added to derbynet._Suite?

> convert derbynet/getCurrentProperties.java to junit
> ---------------------------------------------------
>                 Key: DERBY-3717
>                 URL: https://issues.apache.org/jira/browse/DERBY-3717
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions:
>            Reporter: Manjula Kutty
>            Assignee: Manjula Kutty
>         Attachments: DERBY_3717_06_10_diff.txt, DERBY_3717_06_10_stat.txt, DERBY_3717_07_22_diff.txt,
DERBY_3717_07_22_stat.txt, DERBY_3717_diff.txt, DERBY_3717_stat.txt
> Place holder to contribute the convered test

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message