db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3750) Convert "org.apache.derbyTesting.functionTests.tests.lang.constant Expression.sql" to junit
Date Thu, 10 Jul 2008 16:40:32 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612561#action_12612561
] 

Kathey Marsden commented on DERBY-3750:
---------------------------------------

I think it would be better if these were local variables to the fixtures where they are used.
    private static final String SELECT_SQL = "select * from t1 where ";
    private static final String[][] CONTENT ={
        {"1",}, {"2",}, {"3",},
    } ;
    private PreparedStatement ps1;    
    private PreparedStatement ps2;

Otherwise it looks fine.

Kathey


> Convert  "org.apache.derbyTesting.functionTests.tests.lang.constant Expression.sql" to
junit
> --------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3750
>                 URL: https://issues.apache.org/jira/browse/DERBY-3750
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>         Environment: windows xp, sp2.
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>         Attachments: derby-3750-1-patch.txt, derby-3750-1-stat.txt, derby-3750-patch.txt,
derby-3750-stat.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Convert  "org.apache.derbyTesting.functionTests.tests.lang.constant Expression.sql" to
junit. It it a part of 2008 GSOC.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message