db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Created: (DERBY-3798) Remove unnecessary call to Hashtable.get() in TableScanResultSet.getNextRowCore()
Date Fri, 25 Jul 2008 09:47:31 GMT
Remove unnecessary call to Hashtable.get() in TableScanResultSet.getNextRowCore()
---------------------------------------------------------------------------------

                 Key: DERBY-3798
                 URL: https://issues.apache.org/jira/browse/DERBY-3798
             Project: Derby
          Issue Type: Improvement
          Components: Newcomer, SQL
    Affects Versions: 10.5.0.0
            Reporter: Knut Anders Hatlen
            Priority: Trivial


I came across this piece of code in TableScanResultSet.getNextRowCore():

						if (past2FutureTbl.get(rowLoc) != null)
						{
							past2FutureTbl.remove(rowLoc);
							continue;
						}

I believe the call to Hashtable.get() is unnecessary since Hashtable.remove() returns the
object it removed or null if the key was not in the table. So I believe the code could be
simplified like this without changing the behaviour:

    if (past2FutureTbl.remove(rowLoc) != null) {
        continue;
    }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message