db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Created: (DERBY-3784) ImportExportTest doesn't detect lack of expected errors
Date Fri, 18 Jul 2008 21:41:31 GMT
ImportExportTest doesn't detect lack of expected errors
-------------------------------------------------------

                 Key: DERBY-3784
                 URL: https://issues.apache.org/jira/browse/DERBY-3784
             Project: Derby
          Issue Type: Bug
          Components: Test
    Affects Versions: 10.5.0.0
            Reporter: Knut Anders Hatlen
            Priority: Minor


I observed that ImportExportTest contains many test cases which do try/catch/assertSQLException,
but none of them call fail() at the end of the try block. Example:

	public void testEarlyEndOfFile() throws Exception {
		Connection c = getConnection();
		try {
			doImportFromFile(c, "extin/EndOfFile.txt" , "T4" , null , null , null, 0);
		} catch (SQLException e) {
			assertSQLState("XIE0E", e);
		}
	}

I think this means that if the expected exception isn't thrown the test still passes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message