db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3751) Convert case.sql to junit
Date Wed, 02 Jul 2008 14:43:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609940#action_12609940
] 

Kristian Waagan commented on DERBY-3751:
----------------------------------------

Hello Junjie,

Thanks for the patch.
Below are some comments after a quick look at the first revision:

 1) Are you sure 'CaseExpressionTest' is the best place to put the test?

 2) I don't see much value in the assertEquals for the create
    statements.
    If the statement fails because of case sensitivity, it will throw an
    SQLException.

 3) I think the results from the select statements should be verified by
    using a helper method from the JDBC utility class. You can find the
    class in the package org.apache.derbyTesting.junit.
    I don't understand the use of 'getFetchSize()'.


As a committer, I would also appreciate a stat file (genereated by 'svn
stat') for patches like this where files are deleted (or added). 
It makes it easier to avoid leaving empty files in the repository :)


Thank you, keep up the good work!


regards,

> Convert case.sql to junit
> -------------------------
>
>                 Key: DERBY-3751
>                 URL: https://issues.apache.org/jira/browse/DERBY-3751
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>         Environment: Windows Xp, sp2.
>            Reporter: Junjie Peng
>            Assignee: Junjie Peng
>         Attachments: derby-3751-patch.txt
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> In the package "org.apache.derbyTesting.functionTests.tests.lang", we have both "CaseExpressionTest.java"
 and "case.sql", which are both about case.  Now, I would like to convert "case.sql" to junit,
and I will add new test cases into "CaseExpressionTest.java" ?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message