db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3783) LOBStreamControl shoudn't throw SQLException
Date Thu, 17 Jul 2008 09:17:32 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-3783:
-----------------------------------

    Attachment: derby-3783-1a-dont_throw_sqlexception.stat
                derby-3783-1a-dont_throw_sqlexception.diff

'derby-3783-1a-dont_throw_sqlexception.diff' makes LOBStreamControl throw StandardException
instead of SQLException.
I've tried to change as little as possible, but there was logic in some of the catch blocks
that had to be moved.

I've run jdbcapi._Suite without failures, running suites.All and derbyall now.
I plan to commit (or post a new patch) once the tests have completed. Patch ready for review.

> LOBStreamControl shoudn't throw SQLException
> --------------------------------------------
>
>                 Key: DERBY-3783
>                 URL: https://issues.apache.org/jira/browse/DERBY-3783
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 10.4.1.4, 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-3783-1a-dont_throw_sqlexception.diff, derby-3783-1a-dont_throw_sqlexception.stat
>
>
> LOBStreamControl throws three types of exceptions: IOException, SQLException and StandardException.
> All the SQLException are generated/thrown from the code in LOBStreamControl.
> At this level of the code, SQLException should not be thrown, as it is more tedious to
handle both SQLException and StandardException at higher levels.
> I propose to replace SQLException with StandardException in LOBStreamControl. The purpose
of this change is consistency, and also results it slightly less code at higher levels.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message