db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3800) Convert derbynet/maxthreads to JUnit
Date Thu, 31 Jul 2008 19:22:33 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618819#action_12618819

Kathey Marsden commented on DERBY-3800:

Thanks Suran for the patch.

- There seem to be a lot of white space changes, not related to the patch which make it hard
to read.   It would be better if the patch did not include white space changes.
- I don't think we should have a static NetworkServerControl as it never gets cleaned up.
Fixtures that need it can instantiate their own NetworkServerControl.  That way too I think
you can avoid making suite() throw an exception.
- testMaxThreadsInvalid can set maxthread to a valid value before trying to set it to an invalid
value, so you can verify that the valid value is still set.

> Convert derbynet/maxthreads to JUnit
> ------------------------------------
>                 Key: DERBY-3800
>                 URL: https://issues.apache.org/jira/browse/DERBY-3800
>             Project: Derby
>          Issue Type: Task
>          Components: Test
>            Reporter: Suran Jayathilaka
>            Assignee: Suran Jayathilaka
>         Attachments: derby-3800-1.diff
> Convert derbynet/maxthreads.java test into a JUnit testcase.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message