db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DERBY-3796) Convert derbynet/OutBufferedStream to JUnit
Date Thu, 31 Jul 2008 21:14:33 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren resolved DERBY-3796.
---------------------------------------

    Resolution: Fixed
    Derby Info:   (was: [Patch Available])

Thx for the patch.
I reviewed and committed patch Derby-3796_1.diff with revision 681487 with one modification:
I undid the location change of the import of junit.framework.Test* and TestSuite in derbynet/_Suite.java.

We don't have a policy for sequencing the imports, so the move was not needed...
We do have a policy to separate cosmetic changes from changes required to resolve the issue,
so the move would be frowned upon in that context. 
I probably also should've undone the white-space changes in _Suite.java, but found it too
much bother.

Please next time try to hold  the whitespace changes...(even if it looks nicer).
Also, it would've been nice to know what tests you ran for the patch.

> Convert derbynet/OutBufferedStream to JUnit
> -------------------------------------------
>
>                 Key: DERBY-3796
>                 URL: https://issues.apache.org/jira/browse/DERBY-3796
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.5.0.0
>            Reporter: Erlend Birkenes
>            Assignee: Erlend Birkenes
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: Derby-3796_1.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message