db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3783) LOBStreamControl shouldn't throw SQLException
Date Fri, 18 Jul 2008 09:16:31 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614678#action_12614678

Knut Anders Hatlen commented on DERBY-3783:

One small suggestion, while you're at it:

+            } else {
+                throw new IOException(se.getMessage());
+            }

To preserve the stack trace: throw (IOException) new IOException(se.getMessage()).initCause(se);

Perhaps we should have a helper method for this, since we seem to need it multiple places
in these classes.

> LOBStreamControl shouldn't throw SQLException
> ---------------------------------------------
>                 Key: DERBY-3783
>                 URL: https://issues.apache.org/jira/browse/DERBY-3783
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions:,
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-3783-1a-dont_throw_sqlexception.diff, derby-3783-1a-dont_throw_sqlexception.stat
> LOBStreamControl throws three types of exceptions: IOException, SQLException and StandardException.
> All the SQLException are generated/thrown from the code in LOBStreamControl.
> At this level of the code, SQLException should not be thrown, as it is more tedious to
handle both SQLException and StandardException at higher levels.
> I propose to replace SQLException with StandardException in LOBStreamControl. The purpose
of this change is consistency, and also results it slightly less code at higher levels.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message