db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3706) NetworkServer console messages should print a time stamp
Date Wed, 02 Jul 2008 19:57:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12610025#action_12610025
] 

Kristian Waagan commented on DERBY-3706:
----------------------------------------

I think the approach is acceptable.
To minimize changes you could consider to let the methods without the boolean argument forward
to the new methods and only use the new ones where required, i.e:
public void consolePropertyMessage(String str) {
    consolePropertyMessage(str, true);
}

public void consolePropertyMessage(String str, boolean printTimeStamp) {
    // The implementation goes here.
}

I leave it up to you to decide, or give others in the community a chance to chime in.
It's just two different ways of doing things.

> NetworkServer console messages should print a time stamp
> --------------------------------------------------------
>
>                 Key: DERBY-3706
>                 URL: https://issues.apache.org/jira/browse/DERBY-3706
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server, Newcomer
>    Affects Versions: 10.3.3.1, 10.4.1.4, 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Suran Jayathilaka
>            Priority: Minor
>         Attachments: derby-3706-2.diff, derby-3706-3.diff, derby-3706-4.diff, derby-3706.diff
>
>
> Network Server console messages should print a time stamp.  Methods that need to be changed
are
> NetworkServerControlImpl., consoleMessage, onsolePropertyMessage and consoleExceptionPrintTrace

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message