Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 95548 invoked from network); 17 Jun 2008 12:56:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Jun 2008 12:56:37 -0000 Received: (qmail 47609 invoked by uid 500); 17 Jun 2008 12:56:39 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 47454 invoked by uid 500); 17 Jun 2008 12:56:38 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 47278 invoked by uid 99); 17 Jun 2008 12:56:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jun 2008 05:56:38 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jun 2008 12:55:57 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 56899234C149 for ; Tue, 17 Jun 2008 05:55:45 -0700 (PDT) Message-ID: <872623602.1213707345353.JavaMail.jira@brutus> Date: Tue, 17 Jun 2008 05:55:45 -0700 (PDT) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-2031) Convert derbynet/testProtocol.java to JUnit In-Reply-To: <12104694.1162486458063.JavaMail.root@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-2031: ----------------------------------- Derby Info: [Patch Available] > Convert derbynet/testProtocol.java to JUnit > ------------------------------------------- > > Key: DERBY-2031 > URL: https://issues.apache.org/jira/browse/DERBY-2031 > Project: Derby > Issue Type: Improvement > Components: Network Server, Test > Affects Versions: 10.3.1.4 > Reporter: Knut Anders Hatlen > Assignee: Kristian Waagan > Priority: Minor > Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff, derby-2031-1a-grammar_enum.stat > > > testProtocol.java executes DRDA commands from a file written in a special-purpose language. The statements are very much like assertions, so it should be fairly easy to convert the test to JUnit. > Suggested approach: Change the interpreter (TestProto.java) so that is uses Assert.fail() instead of System.err.println() and System.exit(), and BaseTestCase.println() instead of System.out.println(). It should also use TestConfiguration to get the host name and port number. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.