db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3663) Convert store/streamingColumn to JUnit
Date Mon, 09 Jun 2008 18:03:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603630#action_12603630
] 

Kathey Marsden commented on DERBY-3663:
---------------------------------------

Thanks Suran for converting this huge test.  I think it is getting very close. Just a couple
of nits.  There is some code like this:
try {
			psu2.setBinaryStream(1, new ByteArrayInputStream(buf), len);
			psu2.setAsciiStream(2, new ByteArrayInputStream(buf), len);
			psu2.setInt(3, 0);
			rowCount += psu2.executeUpdate();
			println("DERBY500 #2 Rows updated  =" + rowCount);
		} catch (SQLException sqle) {
			println("UNEXPECTED EXCEPTION - update should have actually gone through");
			throw sqle;
		}

Where you catch the exception, just to throw it again. I think it would be better to just
remove the try/catch blocks and let the exception be thrown.

The code should be reformatted to have space indentation instead of tabs.

There were a couple of properties in the streamingColumn_derby.properties which should probably
be set for the test. you can use SystemPropertyTestSetup to set these.

derby.storage.sortBufferMax=5
derby.debug.true=testSort

I noticed these jvmflags  in the app.properties
jvmflags=-ms32M^-mx128M

Looking back into the archives this was added a long time ago to increase the memory available
not to restrict memory for the test, so I think it is ok to just run with the default memory
configuration with modern jvms.


> Convert store/streamingColumn to JUnit
> --------------------------------------
>
>                 Key: DERBY-3663
>                 URL: https://issues.apache.org/jira/browse/DERBY-3663
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Suran Jayathilaka
>            Assignee: Suran Jayathilaka
>         Attachments: derby-3663-1.diff, derby-3663-2.diff, derby-3663-3.diff
>
>
> Convert org.apache.derbyTesting.functionTests.tests.store.streamingColumn to a JUnit
testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message