db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2031) Convert derbynet/testProtocol.java to JUnit
Date Mon, 30 Jun 2008 10:03:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609197#action_12609197
] 

Knut Anders Hatlen commented on DERBY-2031:
-------------------------------------------

The changes look OK to me. Perhaps a small comment could be added in SecurityManagerTestSetup
to explain when ppTesting is null and non-null. I tried the junit-pptesting target and all
the tests ran successfully.

> Convert derbynet/testProtocol.java to JUnit
> -------------------------------------------
>
>                 Key: DERBY-2031
>                 URL: https://issues.apache.org/jira/browse/DERBY-2031
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server, Test
>    Affects Versions: 10.3.1.4
>            Reporter: Knut Anders Hatlen
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.5.0.0
>
>         Attachments: d2031.diff, d2031.stat, derby-2031-1a-grammar_enum.diff, derby-2031-1a-grammar_enum.stat,
derby-2031-2a-test.diff, derby-2031-3a-enable_test.diff, derby-2031-3a-enable_test.stat
>
>
> testProtocol.java executes DRDA commands from a file written in a special-purpose language.
The statements are very much like assertions, so it should be fairly easy to convert the test
to JUnit.
> Suggested approach: Change the interpreter (TestProto.java) so that is uses Assert.fail()
instead of System.err.println() and System.exit(), and BaseTestCase.println() instead of System.out.println().
It should also use TestConfiguration to get the host name and port number.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message