db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3701) java.lang.Exception: DRDA_UnableToAccept.S:Unable to accept connections and client hang if tracing is turned on but traceDirectory does not exist
Date Fri, 06 Jun 2008 18:30:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12603128#action_12603128
] 

Mamta A. Satoor commented on DERBY-3701:
----------------------------------------

Kathey, i went through the patch and just have couple comments.

For DssTrace.java, there is following code in the diff file,
                Exception e = pae.getException();
                if (e instanceof SecurityException)
-                   throw (SecurityException)pae.getException();
+                   throw (SecurityException) e;
                else
-                   throw (IOException) pae.getException();
+                   throw (IOException) e;

Do we need to know what kind of exception it is before we throw it? In other words, could
we just do?
                Exception e = pae.getException();
+               throw e;
-                if (e instanceof SecurityException)
-                   throw (SecurityException)pae.getException();
-                else
-                   throw (IOException) pae.getException();


Also, I wonder if it will be good to test that /trace/Server1.trace does not exist after making
a Connection in xtestTraceSystemPropertiesNoPermission test.

Other than that, the patch looks good to me.

> java.lang.Exception: DRDA_UnableToAccept.S:Unable to accept connections and client hang
if tracing is turned on but traceDirectory does not exist
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3701
>                 URL: https://issues.apache.org/jira/browse/DERBY-3701
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server
>    Affects Versions: 10.3.2.1, 10.3.3.0, 10.4.1.3, 10.5.0.0
>            Reporter: Kathey Marsden
>            Assignee: Kathey Marsden
>         Attachments: derby-3701_diff.txt, derby-3701_try1_diff.txt, DerbyIssue.java
>
>
> Attempting to connect to network server if  derby.drda.traceAll is set to true and  derby.drda.traceDirectory
is set to a non-existent directory causes the following exception on the console when the
client attempts to connect and causes the client to hang.
> java.lang.Exception: DRDA_UnableToAccept.S:Unable to accept connections.
>         at org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessageWork(NetworkServerControlImpl.java:
> 3172)
>         at org.apache.derby.impl.drda.NetworkServerControlImpl.consolePropertyMessage(NetworkServerControlImpl.java:1829
> )
>         at org.apache.derby.impl.drda.ClientThread.run(ClientThread.java:116)
> See attached program DerbyIssue.java for reproducible test case.
> This is a regression. It did not occur with 10.3.1.4.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message