db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3722) Add circularity check for the GRANT role statement
Date Mon, 16 Jun 2008 07:59:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605215#action_12605215
] 

Kristian Waagan commented on DERBY-3722:
----------------------------------------

A few nits:
 1) Mixed use of tabs and spaces.
 2) No JavaDoc for 'checkCircularity' (intentional?)
 3) Typo: +	 * Currently, we always reads from SYSROLES.
 4) By quickly looking at the test 'checkGrantCircularity', it is not clear to me what is
supposed to happen.
    Add two lines of comments, stating first block of statements should succeed and the second
block of statements should cause the role circularity logic to thrown an exception?
 5) +     *         unseen node (grantee or rolename, depending in
    "in" should be "on"?
 6) + * <bold>or</bold> one &kt;grant role statement&gt;, section 12.5.
    &kt should be &lt?

[RoleClosureIteratorImpl]
 7) Unused imports.
 8) Make 'inverse' final to signal it doesn't change during the RCII objects lifetime?
 9) A typo and a superfluous '(' in the JavaDoc? 

[GrantRoleConstantAction]
 10) 'grantor' in checkCircularity isn't used. Is it there for future requirements?

I have *not* reviewed all the code.

Applied the patch and started regression tests.

> Add circularity check for the GRANT role statement
> --------------------------------------------------
>
>                 Key: DERBY-3722
>                 URL: https://issues.apache.org/jira/browse/DERBY-3722
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Security, SQL
>            Reporter: Dag H. Wanvik
>            Assignee: Dag H. Wanvik
>             Fix For: 10.5.0.0
>
>         Attachments: derby-3722-1.diff, derby-3722-1.stat
>
>
> When a role is granted to another role (with the GRANT <role> statement), we need
to check that the grant relation does not give rise to a circularity. This is described in
Section 12.5, Syntax rule 1 of ISO/IEC 9075-2 2003.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message