db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3717) convert derbynet/getCurrentProperties.java to junit
Date Tue, 10 Jun 2008 21:05:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604042#action_12604042
] 

Kristian Waagan commented on DERBY-3717:
----------------------------------------

A few comments on the test:
 1) Is it safe to assume a specific order for the properties?
    I'm thinking if different JVM implementations, or versions, might give a different ordering.
 2) Why not just set the Properties object to null at declaration to avoid the extra nullifying?
(see inside the catch-block)
 3) Add a comment for "Connection conn = getConnection();" in testPropertiesAfterConnection,
since it is never used?
 4) If getting the property object from NetworkServerControl fails, I think there is an alternative
way to preserve the stack-trace. I think Dag figured out how.
 5) "testPropertiesBeforeConnection" never throws Exception.
 6) A few lines with wrong indentation.
 7) First line of the class JavaDoc should be moved one line down.

Except for possibly issue 1, the comments are just nits and should not stop a commit.
Thank you for the patch :)


> convert derbynet/getCurrentProperties.java to junit
> ---------------------------------------------------
>
>                 Key: DERBY-3717
>                 URL: https://issues.apache.org/jira/browse/DERBY-3717
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.4.1.4
>            Reporter: Manjula Kutty
>            Assignee: Manjula Kutty
>         Attachments: DERBY_3717_06_10_diff.txt, DERBY_3717_06_10_stat.txt
>
>
> Place holder to contribute the convered test

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message