db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3717) convert derbynet/getCurrentProperties.java to junit
Date Mon, 23 Jun 2008 09:47:45 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Kristian Waagan updated DERBY-3717:

    Derby Info:   (was: [Patch Available])

Thanks for the reviewed patch Manjula.

I tried it out, and got some failures. Maybe they're expected, but I'll comment on them anyway.
 1) The test cannot be run repeatedly with an existing database *and* a failure, as the table
being created will exist after the first execution.
    I think this can be easily fixed by changing "Connection conn = getConnection" with "getConnection.setAutoCommit(false)"
and remove the table deletion at the end.

 2) With an existing database, there's one property missing.
    It seems "derby.drda.trace.4" isn't set when the database / trace file exists. Do you
know why?

Also, some other comments:
 a) Could PrivilegedFileOpsForTests.exists be used instead of duplication of code?
 b) Do "Properties p = null" to avoid special code (i.e. setting p = null in the catch clause),
or just remove the try-catch block.
 c) Use "fail(String,Exception)" instead of printStackTrace (if try-catch is kept).
 d) Create a Properties object instead of just a String array with values?
    As it is now, it's not possible to see which property a value is for. This is dependent
on the order of the properties returned by NetworkServerControl.getCurrentProperties(), or
rather the order returned by the enumerator.
 e) Why isn't "makeServerPolicyName" static?
 f) Indentation.
 g) Wrong file name in the header for the policy file.


> convert derbynet/getCurrentProperties.java to junit
> ---------------------------------------------------
>                 Key: DERBY-3717
>                 URL: https://issues.apache.org/jira/browse/DERBY-3717
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions:
>            Reporter: Manjula Kutty
>            Assignee: Manjula Kutty
>         Attachments: DERBY_3717_06_10_diff.txt, DERBY_3717_06_10_stat.txt, DERBY_3717_diff.txt,
> Place holder to contribute the convered test

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message