db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3151) Reduce dependency on NetworkServerControl in TestConfiguration
Date Wed, 11 Jun 2008 09:22:47 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-3151:
-----------------------------------

    Attachment: derby-3151-3a-test.diff
                derby-3151-2a-wrapper.stat
                derby-3151-2a-wrapper.diff

Attaching another fix and a test to demonstrate the problem/fix (see earlier comment for how
to run the test).

'derby-3151-2a-wrapper.diff' removes references to NetworkServerControl in TestConfiguration,
and uses a wrapper class to start and shutdown a server. I tried using an existing class (NetworkServerTestSetup),
but wasn't able to do that easily.
Note that the wrapper class is only intended to solve the problem related to importing NetworkServerControl
in TestConfiguration.

Patch ready for review.
Is the patch solving  a problem, or am I just adding complexity?

> Reduce dependency on NetworkServerControl in TestConfiguration
> --------------------------------------------------------------
>
>                 Key: DERBY-3151
>                 URL: https://issues.apache.org/jira/browse/DERBY-3151
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.4.1.3
>            Reporter: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-3151-1a-proposal.diff, derby-3151-2a-wrapper.diff, derby-3151-2a-wrapper.stat,
derby-3151-3a-test.diff
>
>
> Code has been added in TestConfiguration to allow for starting and stopping a Derby network
server.
> Even if you know will not need this functionality, or you simply don't want to have this
functionality available, you must include derbynet.jar (or point to classes/).
> I think this dependency should be reduced, by not having any instance variables and by
not importing the class with an explicit import statement. The existing instance variables
are not used.
> With this planned change, you can run tests without including derbynet.jar on the classpath,
as long as they don't call 'startNetworkServer' or 'stopNetworkServer'. Most often these methods
will be called by a decorator.
> The downside of this change, is that you won't get any error messages before the mentioned
methods are actually executed.
> A typical error message:
> Failed to invoke suite():java.lang.NoClassDefFoundError: org/apache/derby/drda/NetworkServerControl
> I'm sure there are other solutions as well, but this one is really easy.
> Any opinions on this change?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message