Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 82630 invoked from network); 20 May 2008 19:12:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 20 May 2008 19:12:18 -0000 Received: (qmail 65893 invoked by uid 500); 20 May 2008 19:12:18 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 65843 invoked by uid 500); 20 May 2008 19:12:18 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 65829 invoked by uid 99); 20 May 2008 19:12:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 May 2008 12:12:18 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 May 2008 19:11:40 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D4B3B234C11B for ; Tue, 20 May 2008 12:11:55 -0700 (PDT) Message-ID: <722258893.1211310715870.JavaMail.jira@brutus> Date: Tue, 20 May 2008 12:11:55 -0700 (PDT) From: "Knut Anders Hatlen (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-1062) Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing alter table In-Reply-To: <412439192.1141079095096.JavaMail.jira@ajax.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Knut Anders Hatlen updated DERBY-1062: -------------------------------------- Attachment: d1062-escape.diff It's actually very simple to fix (see the attached patch d1062-escape.diff), so I'd rather see both of the procedures fixed than both of them broken. I haven't run any tests on the patch, but I'll do so and commit it if there are no objections to this approach. I'll also add a test case. > Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing alter table > ----------------------------------------------------------------------------------------------- > > Key: DERBY-1062 > URL: https://issues.apache.org/jira/browse/DERBY-1062 > Project: Derby > Issue Type: Improvement > Components: Newcomer, SQL, Store > Affects Versions: 10.1.3.1 > Reporter: Mike Matrigali > Assignee: Mamta A. Satoor > Priority: Minor > Attachments: d1062-escape.diff > > > Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing alter table > code. One suggested approach is to use the same mechanism as SYSCS_COMPRESS_TABLE. Such > an implementation would involve: > o change the parser for alter table to accecpt some internal only syntax for SYSCS_INPLACE_COMPRESS_TABLE > o change the alter table constant action to get the required information for inplace compress > o move most of the inplace compress driving code to a routine in alter table execution, following the same > coding pattern as existing alter table compress. > I believe doing this will have multiple benefits: > 1) shares existing alter table code, so things like error checking, security management, ... is all done by one piece of code > 2) by sharing the code I believe the following outstanding JIRA issues will be addressed: DERBY-719, DERBY-720 - > 3) future changes addressing ddl like grant/revoke will automatically work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.