db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Knut Anders Hatlen <Knut.Hat...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-1062) Change the internal implemetation of SYSCS_INPLACE_COMPRESS_TABLE to share existing alter table
Date Thu, 22 May 2008 07:39:32 GMT
Dag.Wanvik@Sun.COM (Dag H. Wanvik) writes:

> "Knut Anders Hatlen (JIRA)" <jira@apache.org> writes:
>
>>     [ https://issues.apache.org/jira/browse/DERBY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598645#action_12598645
] 
>>
>> Knut Anders Hatlen commented on DERBY-1062:
>> -------------------------------------------
>>
>> Thanks Bryan, I did a quick search to see if we had a utility method
>> but couldn't find one. The one in IdUtil seems to be fine,
>> though. To fix SYSCS_BULK_INSERT (see DERBY-3682), we'll need a
>> similar one for string literals. The only difference is that it uses
>> single quotes instead of double quotes. Do you know if we have a
>> utility method for string literals too?
>
> I have been looking at identifier mapping code as part of
> DERBY-3673. I realize I can user IdUtil#normalToDelimited to save
> redundancy as well. FYI, I also moved some code which I needed to use
> from the parser (compressQuotes) to StringUtil . It would be nice if
> we can clean up mapping code between external and internal forms and
> have it in one place.

Thanks Dag. StringId.compressQuotes() is the inverse function of what
I'm looking for, so I guess it would be fine to add a quoteString()
function to that class.

-- 
Knut Anders

Mime
View raw message