db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rick Hillegas <Richard.Hille...@Sun.COM>
Subject Re: [jira] Commented: (DERBY-3531) DatabasePermission uses a JDK 1.4 method that is not present in J2ME/CDC/Foundation.
Date Fri, 30 May 2008 13:03:54 GMT
Kristian Waagan wrote:
> Kristian Waagan (JIRA) wrote:
>>     [ 
>> https://issues.apache.org/jira/browse/DERBY-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601070#action_12601070

>> ]
>> Kristian Waagan commented on DERBY-3531:
>> ----------------------------------------
>> Thanks for the updated patch Martin.
>> I still see indentation issues though. Personally I try to never 
>> include tabs in the code, but I don't think this has been documented 
>> or formally decided for Derby.
> Actually, seems we have tried to standardize this issue. However, the 
> documentation we have on it is not very clear or easy to follow.
Hi Kristian,

Here's what the community approved: 

We are supposed to use spaces rather than tabs and indentation should be 
4 spaces according to the included standard 
(http://java.sun.com/docs/codeconv/html/CodeConvTOC.doc.html). However, 
we also allowed ourselves plenty of wiggle room in old code.
> The vote is documented on the wiki, but it is not easy to see what we 
> actually voted for. The contributer checklist on the wiki says we 
> haven't decided anything; "The Derby community has not approved a 
> common body of coding standards".
According to the vote, the coding standard was supposed to have been 
copied onto the contributor checklist wiki page 
(http://wiki.apache.org/db-derby/DerbyContributorChecklist). Looks like 
that never happened. The "Coding Standard" line on that page looks stale 
to me.
> Maybe we should try to clear this up?
I agree that it would be a good idea to clean up the contributor checklist.


View raw message